practicing hours

Hi Camille I practice everyday usally for about 1-3 hours for the past year how long do you think its going to take to have a really good voice

Hi, Gabriella! Do you feel that you're making improvement from where you started? I can't give you a timeline, but I would certainly expect improvement within that time. If you feel like you're stuck, please see below for a few articles with ideas for you:

https://www.30daysinger.com/blog/how-to-improve-your-singing-voice-steps-to-follow-for-self-study

https://www.30daysinger.com/blog/getting-better-fast-when-will-i-hear-improvement-in-my-voice

https://www.30daysinger.com/how-to-sing

I think I improved so much but meaning like I improved my voice not like meaning it sounds good like i improved with my technique,vibrato and everything but I dont have a stable vibrato

Glad to hear you've seen improvement! To train a more stable vibrato, I'd do a few things:

1. Always be aware of your breath support and develop a connection between your onset (the way you start a note) and your belly engaging.

2. Find places in your range where your vibrato does sound consistent, and move from there to a less consistent spot. For example, if C4 is very consistent but G4 isn't, you could find your vibrato on C4 and then slide to G4 without changing anything. 

3. Work on shorter notes now, and sustain later. Sustains are difficult! See if you can get a consistent vibrato with shorter sustains before elongating. 

Hope that helps, Gabriella!